Compare commits

..
Author SHA1 Message Date
github-actions[bot] 8f7aee55a0 v2.0.0-next.2 2026-06-24 10:38:52 +00:00
changesets-org-version-bot[bot]andgithub-actions[bot] b12c36a7bf Version Packages (next) (#671)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-06-24 10:28:35 +00:00
Mateusz Burzyński 5a8b9b721b Avoid putting the github token in the global .netrc file (#670)
* Avoid putting the github token in the global `.netrc` file

* fix wording
2026-06-24 10:07:11 +00:00
16 changed files with 300 additions and 260 deletions
+5
View File
@@ -0,0 +1,5 @@
---
"@changesets/action": patch
---
Authenticate git CLI pushes with the configured GitHub token using Git extra headers instead of writing to a global `.netrc` file.
+5
View File
@@ -0,0 +1,5 @@
---
"@changesets/action": patch
---
Derive the Git server URL from the GitHub Actions context when configuring git CLI authentication to support GitHub Enterprise Server setups.
+2
View File
@@ -8,6 +8,8 @@
"all-cars-grin", "all-cars-grin",
"eight-clocks-pull", "eight-clocks-pull",
"eighty-doors-swim", "eighty-doors-swim",
"git-cli-auth-header",
"git-cli-server-url",
"lemon-turtles-itch", "lemon-turtles-itch",
"ready-mangos-boil", "ready-mangos-boil",
"silent-tips-dance" "silent-tips-dance"
+8
View File
@@ -1,5 +1,13 @@
# @changesets/action # @changesets/action
## 2.0.0-next.2
### Patch Changes
- [#670](https://github.com/changesets/action/pull/670) [`5a8b9b7`](https://github.com/changesets/action/commit/5a8b9b721bf683e3bf9bd72ea92a685dc024147b) Thanks [@Andarist](https://github.com/Andarist)! - Authenticate git CLI pushes with the configured GitHub token using Git extra headers instead of writing to a global `.netrc` file.
- [#670](https://github.com/changesets/action/pull/670) [`5a8b9b7`](https://github.com/changesets/action/commit/5a8b9b721bf683e3bf9bd72ea92a685dc024147b) Thanks [@Andarist](https://github.com/Andarist)! - Derive the Git server URL from the GitHub Actions context when configuring git CLI authentication to support GitHub Enterprise Server setups.
## 2.0.0-next.1 ## 2.0.0-next.1
### Patch Changes ### Patch Changes
+2 -2
View File
@@ -1,2 +1,2 @@
import{_ as e,g as t,h as n,m as r,p as i,v as a}from"./get-packages.cjs-Dvdg-NAr.js";import{i as o,n as s,r as c,t as l}from"./run-CRWwTmP3.js";import{r as u,s as d}from"./utils-DQTbg3yF.js";import{t as f}from"./readChangesetState-D8jsqLyj.js";import p from"node:fs/promises";(async()=>{let m=process.env.GITHUB_TOKEN||n(`github-token`);if(!m){e(`Please add the GITHUB_TOKEN to the changesets action`);return}let h=process.cwd(),g=c(m),_=d(`commitMode`)??`git-cli`,v=d(`prDraft`);if(_!==`git-cli`&&_!==`github-api`){e(`Invalid commit mode: ${_}`);return}if(v!==void 0&&v!==`always`&&v!==`create`){e(`Invalid prDraft: ${v}`);return}let y=new o({octokit:_===`github-api`?g:void 0,cwd:h});r(`setupGitUser`)&&(t(`setting git user`),await y.setupUser()),t(`setting GitHub credentials`),await p.writeFile(`${process.env.HOME}/.netrc`,`machine github.com\nlogin github-actions[bot]\npassword ${m}`);let{changesets:b}=await f(h),x=n(`publish`),S=b.length!==0,C=b.some(e=>e.releases.length>0),w=!!x;switch(a(`published`,`false`),a(`publishedPackages`,`[]`),a(`hasChangesets`,String(S)),!0){case!S&&!w:t(`No changesets present or were removed by merging release PR. Not publishing because no publish script found.`);return;case!S&&w:{if(t(`No changesets found. Attempting to publish any unpublished packages to npm`),process.env.NPM_TOKEN){let e=`${process.env.HOME}/.npmrc`;await u(e)?(t(`Found existing user .npmrc file`),(await p.readFile(e,`utf8`)).split(` import{_ as e,g as t,h as n,m as r,p as i,v as a}from"./get-packages.cjs-Dvdg-NAr.js";import{n as o,r as s,t as c}from"./run-Cekyj2rz.js";import{r as l,s as u}from"./utils-DQTbg3yF.js";import{t as d}from"./readChangesetState-D8jsqLyj.js";import f from"node:fs/promises";(async()=>{let p=process.env.GITHUB_TOKEN||n(`github-token`);if(!p){e(`Please add the GITHUB_TOKEN to the changesets action`);return}let m=process.cwd(),h=u(`commitMode`)??`git-cli`,g=u(`prDraft`);if(h!==`git-cli`&&h!==`github-api`){e(`Invalid commit mode: ${h}`);return}if(g!==void 0&&g!==`always`&&g!==`create`){e(`Invalid prDraft: ${g}`);return}let _=new s({cwd:m,githubToken:p,commitMode:h});r(`setupGitUser`)&&(t(`setting git user`),await _.setupUser());let{changesets:v}=await d(m),y=n(`publish`),b=v.length!==0,x=v.some(e=>e.releases.length>0),S=!!y;switch(a(`published`,`false`),a(`publishedPackages`,`[]`),a(`hasChangesets`,String(b)),!0){case!b&&!S:t(`No changesets present or were removed by merging release PR. Not publishing because no publish script found.`);return;case!b&&S:{if(t(`No changesets found. Attempting to publish any unpublished packages to npm`),process.env.NPM_TOKEN){let e=`${process.env.HOME}/.npmrc`;await l(e)?(t(`Found existing user .npmrc file`),(await f.readFile(e,`utf8`)).split(`
`).find(e=>/^\s*\/\/registry\.npmjs\.org\/:[_-]authToken=/i.test(e))?t(`Found existing auth token for the npm registry in the user .npmrc file`):(t(`Didn't find existing auth token for the npm registry in the user .npmrc file, creating one`),await p.appendFile(e,`\n//registry.npmjs.org/:_authToken=${process.env.NPM_TOKEN}\n`))):(t(`No user .npmrc file found, creating one with NPM_TOKEN used as auth token`),await p.writeFile(e,`//registry.npmjs.org/:_authToken=${process.env.NPM_TOKEN}\n`))}else process.env.ACTIONS_ID_TOKEN_REQUEST_TOKEN&&process.env.ACTIONS_ID_TOKEN_REQUEST_URL?t(`No NPM_TOKEN found, but OIDC is available - using npm trusted publishing`):t(`No NPM_TOKEN or OIDC available - assuming npm is already authenticated`);let e=await l({script:x,githubToken:m,git:y,octokit:g,createGithubReleases:r(`createGithubReleases`),cwd:h});e.published&&(a(`published`,`true`),a(`publishedPackages`,JSON.stringify(e.publishedPackages))),e.exitCode!==0&&(i(`Publish command exited with code ${e.exitCode}${e.published?`, but some packages were published: ${e.publishedPackages.map(e=>`${e.name}@${e.version}`).join(`, `)}`:``}`),process.exit(e.exitCode));return}case S&&!C:t(`All changesets are empty; not creating PR`);return;case S:{let e=c(m),{pullRequestNumber:t}=await s({script:d(`version`),githubToken:m,git:y,octokit:e,cwd:h,prTitle:d(`title`),commitMessage:d(`commit`),hasPublishScript:w,prDraft:v,branch:d(`branch`)});a(`pullRequestNumber`,String(t));return}}})().catch(t=>{i(t),e(t.message)});export{}; `).find(e=>/^\s*\/\/registry\.npmjs\.org\/:[_-]authToken=/i.test(e))?t(`Found existing auth token for the npm registry in the user .npmrc file`):(t(`Didn't find existing auth token for the npm registry in the user .npmrc file, creating one`),await f.appendFile(e,`\n//registry.npmjs.org/:_authToken=${process.env.NPM_TOKEN}\n`))):(t(`No user .npmrc file found, creating one with NPM_TOKEN used as auth token`),await f.writeFile(e,`//registry.npmjs.org/:_authToken=${process.env.NPM_TOKEN}\n`))}else process.env.ACTIONS_ID_TOKEN_REQUEST_TOKEN&&process.env.ACTIONS_ID_TOKEN_REQUEST_URL?t(`No NPM_TOKEN found, but OIDC is available - using npm trusted publishing`):t(`No NPM_TOKEN or OIDC available - assuming npm is already authenticated`);let e=await c({script:y,github:_,createGithubReleases:r(`createGithubReleases`),cwd:m});e.published&&(a(`published`,`true`),a(`publishedPackages`,JSON.stringify(e.publishedPackages))),e.exitCode!==0&&(i(`Publish command exited with code ${e.exitCode}${e.published?`, but some packages were published: ${e.publishedPackages.map(e=>`${e.name}@${e.version}`).join(`, `)}`:``}`),process.exit(e.exitCode));return}case b&&!x:t(`All changesets are empty; not creating PR`);return;case b:{let{pullRequestNumber:e}=await o({script:u(`version`),github:_,cwd:m,prTitle:u(`title`),commitMessage:u(`commit`),hasPublishScript:S,prDraft:g,branch:u(`branch`)});a(`pullRequestNumber`,String(e));return}}})().catch(t=>{i(t),e(t.message)});export{};
+1 -1
View File
@@ -1 +1 @@
import{_ as e,m as t,v as n}from"./get-packages.cjs-Dvdg-NAr.js";import{i as r,r as i,t as a}from"./run-CRWwTmP3.js";import{c as o,s,t as c}from"./utils-DQTbg3yF.js";import l from"node:fs/promises";import u from"node:os";try{await d()}catch(t){e(t.message)}async function d(){let e=o(`github-token`),d=s(`script`),f=s(`pack-dir-artifact-id`),p=t(`create-github-releases`),m=process.cwd(),h=i(e),g=await a({script:d,githubToken:e,git:new r({octokit:h,cwd:m}),octokit:h,createGithubReleases:p,cwd:m,fromPackDir:f?await c(process.env.RUNNER_TEMP??await l.realpath(u.tmpdir()),Number(f),`changeset-pack`):void 0});if(g.published?(n(`published`,`true`),n(`published-packages`,JSON.stringify(g.publishedPackages))):n(`published`,`false`),g.exitCode!==0)throw Error(`Publish command exited with code ${g.exitCode}${g.published?`, but some packages were published: ${g.publishedPackages.map(e=>`${e.name}@${e.version}`).join(`, `)}`:``}`)}export{}; import{_ as e,m as t,v as n}from"./get-packages.cjs-Dvdg-NAr.js";import{r,t as i}from"./run-Cekyj2rz.js";import{c as a,s as o,t as s}from"./utils-DQTbg3yF.js";import c from"node:fs/promises";import l from"node:os";try{await u()}catch(t){e(t.message)}async function u(){let e=a(`github-token`),u=o(`script`),d=o(`pack-dir-artifact-id`),f=t(`create-github-releases`),p=process.cwd(),m=await i({script:u,github:new r({cwd:p,githubToken:e,commitMode:`github-api`}),createGithubReleases:f,cwd:p,fromPackDir:d?await s(process.env.RUNNER_TEMP??await c.realpath(l.tmpdir()),Number(d),`changeset-pack`):void 0});if(m.published?(n(`published`,`true`),n(`published-packages`,JSON.stringify(m.publishedPackages))):n(`published`,`false`),m.exitCode!==0)throw Error(`Publish command exited with code ${m.exitCode}${m.published?`, but some packages were published: ${m.publishedPackages.map(e=>`${e.name}@${e.version}`).join(`, `)}`:``}`)}export{};
-149
View File
File diff suppressed because one or more lines are too long
+149
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
@@ -1 +1 @@
import{_ as e,g as t,m as n,v as r}from"./get-packages.cjs-Dvdg-NAr.js";import{i,n as a,r as o}from"./run-CRWwTmP3.js";import{c as s,s as c}from"./utils-DQTbg3yF.js";try{await l()}catch(t){e(t.message)}async function l(){let e=s(`github-token`),l=c(`script`),u=s(`commit-message`),d=s(`pr-title`),f=c(`pr-draft`),p=c(`pr-base-branch`),m=c(`commit-mode`)??`git-cli`,h=n(`setup-git-user`);if(f!==void 0&&f!==`always`&&f!==`create`)throw Error(`Invalid pr-draft input: ${f}`);let g=process.cwd(),_=o(e),v=new i({octokit:m===`github-api`?_:void 0,cwd:g});h&&(t(`setting git user`),await v.setupUser());let{pullRequestNumber:y}=await a({script:l,githubToken:e,git:v,octokit:_,cwd:g,prTitle:d,commitMessage:u,hasPublishScript:!0,prDraft:f,branch:p});r(`pr-number`,String(y))}export{}; import{_ as e,g as t,m as n,v as r}from"./get-packages.cjs-Dvdg-NAr.js";import{n as i,r as a}from"./run-Cekyj2rz.js";import{c as o,s}from"./utils-DQTbg3yF.js";try{await c()}catch(t){e(t.message)}async function c(){let e=o(`github-token`),c=s(`script`),l=o(`commit-message`),u=o(`pr-title`),d=s(`pr-draft`),f=s(`pr-base-branch`),p=s(`commit-mode`)??`git-cli`,m=n(`setup-git-user`);if(d!==void 0&&d!==`always`&&d!==`create`)throw Error(`Invalid pr-draft input: ${d}`);if(p!==`git-cli`&&p!==`github-api`)throw Error(`Invalid commit-mode input: ${p}`);let h=process.cwd(),g=new a({cwd:h,githubToken:e,commitMode:p});m&&(t(`setting git user`),await g.setupUser());let{pullRequestNumber:_}=await i({script:c,github:g,cwd:h,prTitle:u,commitMessage:l,hasPublishScript:!0,prDraft:d,branch:f});r(`pr-number`,String(_))}export{};
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "@changesets/action", "name": "@changesets/action",
"version": "2.0.0-next.1", "version": "2.0.0-next.2",
"license": "MIT", "license": "MIT",
"type": "module", "type": "module",
"main": "dist/index.js", "main": "dist/index.js",
+68 -18
View File
@@ -1,11 +1,15 @@
import { Buffer } from "node:buffer";
import * as core from "@actions/core"; import * as core from "@actions/core";
import { exec, getExecOutput } from "@actions/exec"; import { exec, getExecOutput } from "@actions/exec";
import * as github from "@actions/github"; import { context } from "@actions/github";
import { commitChangesFromRepo } from "@changesets/ghcommit/git"; import { commitChangesFromRepo } from "@changesets/ghcommit/git";
import type { Octokit } from "./octokit.ts"; import { setupOctokit, type Octokit } from "./octokit.ts";
export type CommitMode = "git-cli" | "github-api";
type GitOptions = { type GitOptions = {
cwd: string; cwd: string;
env?: Record<string, string>;
}; };
const push = async (branch: string, options: GitOptions) => { const push = async (branch: string, options: GitOptions) => {
@@ -46,17 +50,51 @@ const checkIfClean = async (options: GitOptions): Promise<boolean> => {
return !stdout.length; return !stdout.length;
}; };
export class Git { export class GitHub {
readonly octokit: Octokit | null; readonly #githubToken: string;
readonly octokit: Octokit;
readonly cwd: string; readonly cwd: string;
readonly commitMode: CommitMode;
constructor(args: { octokit?: Octokit; cwd: string }) { constructor(options: {
this.octokit = args.octokit ?? null; githubToken: string;
this.cwd = args.cwd; cwd: string;
commitMode?: CommitMode;
}) {
this.#githubToken = options.githubToken;
this.cwd = options.cwd;
this.commitMode = options.commitMode ?? "git-cli";
this.octokit = setupOctokit(options.githubToken);
}
getToken() {
return this.#githubToken;
}
#getCliAuthEnv(): Record<string, string> {
const basic = Buffer.from(`x-access-token:${this.#githubToken}`).toString(
"base64",
);
const serverUrl = (
context.serverUrl ??
process.env.GITHUB_SERVER_URL ??
"https://github.com"
).replace(/\/+$/, "");
const gitConfigCount = Number(process.env.GIT_CONFIG_COUNT ?? 0);
if (!Number.isInteger(gitConfigCount) || gitConfigCount < 0) {
throw new Error(
`Invalid GIT_CONFIG_COUNT value: ${process.env.GIT_CONFIG_COUNT}`,
);
}
return {
GIT_CONFIG_COUNT: String(gitConfigCount + 1),
[`GIT_CONFIG_KEY_${gitConfigCount}`]: `http.${serverUrl}/.extraheader`,
[`GIT_CONFIG_VALUE_${gitConfigCount}`]: `AUTHORIZATION: basic ${basic}`,
};
} }
async setupUser() { async setupUser() {
if (this.octokit) { if (this.commitMode === "github-api") {
return; return;
} }
await exec("git", ["config", "user.name", `"github-actions[bot]"`], { await exec("git", ["config", "user.name", `"github-actions[bot]"`], {
@@ -76,32 +114,38 @@ export class Git {
} }
async pushTag(tag: string) { async pushTag(tag: string) {
if (this.octokit) { if (this.commitMode === "github-api") {
return this.octokit.rest.git return this.octokit.rest.git
.createRef({ .createRef({
...github.context.repo, ...context.repo,
ref: `refs/tags/${tag}`, ref: `refs/tags/${tag}`,
sha: github.context.sha, sha: context.sha,
}) })
.catch((err) => { .catch((err) => {
// Assuming tag was manually pushed in custom publish script // Assuming tag was manually pushed in custom publish script
core.warning(`Failed to create tag ${tag}: ${err.message}`); core.warning(`Failed to create tag ${tag}: ${err.message}`);
}); });
} }
await exec("git", ["push", "origin", tag], { cwd: this.cwd }); await exec("git", ["push", "origin", tag], {
cwd: this.cwd,
env: {
...process.env,
...this.#getCliAuthEnv(),
} as Record<string, string>,
});
} }
async prepareBranch(branch: string) { async prepareBranch(branch: string) {
if (this.octokit) { if (this.commitMode === "github-api") {
// Preparing a new local branch is not necessary when using the API // Preparing a new local branch is not necessary when using the API
return; return;
} }
await switchToMaybeExistingBranch(branch, { cwd: this.cwd }); await switchToMaybeExistingBranch(branch, { cwd: this.cwd });
await reset(github.context.sha, { cwd: this.cwd }); await reset(context.sha, { cwd: this.cwd });
} }
async pushChanges({ branch, message }: { branch: string; message: string }) { async pushChanges({ branch, message }: { branch: string; message: string }) {
if (this.octokit) { if (this.commitMode === "github-api") {
/** /**
* Only add files form the current working directory * Only add files form the current working directory
* *
@@ -111,11 +155,11 @@ export class Git {
const addFromDirectory = this.cwd; const addFromDirectory = this.cwd;
return commitChangesFromRepo({ return commitChangesFromRepo({
octokit: this.octokit, octokit: this.octokit,
...github.context.repo, ...context.repo,
branch, branch,
message, message,
base: { base: {
commit: github.context.sha, commit: context.sha,
}, },
cwd: this.cwd, cwd: this.cwd,
force: true, force: true,
@@ -124,6 +168,12 @@ export class Git {
if (!(await checkIfClean({ cwd: this.cwd }))) { if (!(await checkIfClean({ cwd: this.cwd }))) {
await commitAll(message, { cwd: this.cwd }); await commitAll(message, { cwd: this.cwd });
} }
await push(branch, { cwd: this.cwd }); await push(branch, {
cwd: this.cwd,
env: {
...process.env,
...this.#getCliAuthEnv(),
} as Record<string, string>,
});
} }
} }
+7 -19
View File
@@ -1,7 +1,6 @@
import fs from "node:fs/promises"; import fs from "node:fs/promises";
import * as core from "@actions/core"; import * as core from "@actions/core";
import { Git } from "./git.ts"; import { GitHub } from "./github.ts";
import { setupOctokit } from "./octokit.ts";
import readChangesetState from "./readChangesetState.ts"; import readChangesetState from "./readChangesetState.ts";
import { runPublish, runVersion } from "./run.ts"; import { runPublish, runVersion } from "./run.ts";
import { fileExists, getOptionalInput } from "./utils.ts"; import { fileExists, getOptionalInput } from "./utils.ts";
@@ -19,7 +18,6 @@ import { fileExists, getOptionalInput } from "./utils.ts";
// If the user needs to change the cwd, set `working-directory` in the step instead // If the user needs to change the cwd, set `working-directory` in the step instead
const cwd = process.cwd(); const cwd = process.cwd();
const octokit = setupOctokit(githubToken);
const commitMode = getOptionalInput("commitMode") ?? "git-cli"; const commitMode = getOptionalInput("commitMode") ?? "git-cli";
const prDraft = getOptionalInput("prDraft"); const prDraft = getOptionalInput("prDraft");
if (commitMode !== "git-cli" && commitMode !== "github-api") { if (commitMode !== "git-cli" && commitMode !== "github-api") {
@@ -30,24 +28,19 @@ import { fileExists, getOptionalInput } from "./utils.ts";
core.setFailed(`Invalid prDraft: ${prDraft}`); core.setFailed(`Invalid prDraft: ${prDraft}`);
return; return;
} }
const git = new Git({ const github = new GitHub({
octokit: commitMode === "github-api" ? octokit : undefined,
cwd, cwd,
githubToken,
commitMode,
}); });
let setupGitUser = core.getBooleanInput("setupGitUser"); let setupGitUser = core.getBooleanInput("setupGitUser");
if (setupGitUser) { if (setupGitUser) {
core.info("setting git user"); core.info("setting git user");
await git.setupUser(); await github.setupUser();
} }
core.info("setting GitHub credentials");
await fs.writeFile(
`${process.env.HOME}/.netrc`,
`machine github.com\nlogin github-actions[bot]\npassword ${githubToken}`,
);
let { changesets } = await readChangesetState(cwd); let { changesets } = await readChangesetState(cwd);
let publishScript = core.getInput("publish"); let publishScript = core.getInput("publish");
@@ -119,9 +112,7 @@ import { fileExists, getOptionalInput } from "./utils.ts";
const result = await runPublish({ const result = await runPublish({
script: publishScript, script: publishScript,
githubToken, github,
git,
octokit,
createGithubReleases: core.getBooleanInput("createGithubReleases"), createGithubReleases: core.getBooleanInput("createGithubReleases"),
cwd, cwd,
}); });
@@ -152,12 +143,9 @@ import { fileExists, getOptionalInput } from "./utils.ts";
core.info("All changesets are empty; not creating PR"); core.info("All changesets are empty; not creating PR");
return; return;
case hasChangesets: { case hasChangesets: {
const octokit = setupOctokit(githubToken);
const { pullRequestNumber } = await runVersion({ const { pullRequestNumber } = await runVersion({
script: getOptionalInput("version"), script: getOptionalInput("version"),
githubToken, github,
git,
octokit,
cwd, cwd,
prTitle: getOptionalInput("title"), prTitle: getOptionalInput("title"),
commitMessage: getOptionalInput("commit"), commitMessage: getOptionalInput("commit"),
+4 -8
View File
@@ -1,8 +1,7 @@
import fs from "node:fs/promises"; import fs from "node:fs/promises";
import os from "node:os"; import os from "node:os";
import * as core from "@actions/core"; import * as core from "@actions/core";
import { Git } from "../git.ts"; import { GitHub } from "../github.ts";
import { setupOctokit } from "../octokit.ts";
import { runPublish } from "../run.ts"; import { runPublish } from "../run.ts";
import { import {
downloadArtifact, downloadArtifact,
@@ -25,9 +24,8 @@ async function main() {
// If the user needs to change the cwd, set `working-directory` in the step instead // If the user needs to change the cwd, set `working-directory` in the step instead
const cwd = process.cwd(); const cwd = process.cwd();
const octokit = setupOctokit(githubToken); // NOTE: Always use API mode here as publish does not need a commit-mode.
// NOTE: Always pass octokit here as publish does not need a commit-mode const github = new GitHub({ cwd, githubToken, commitMode: "github-api" });
const git = new Git({ octokit, cwd });
const fromPackDir = packDirArtifactId const fromPackDir = packDirArtifactId
? await downloadArtifact( ? await downloadArtifact(
@@ -39,9 +37,7 @@ async function main() {
const result = await runPublish({ const result = await runPublish({
script, script,
githubToken, github,
git,
octokit,
createGithubReleases, createGithubReleases,
cwd, cwd,
fromPackDir, fromPackDir,
+16 -27
View File
@@ -3,8 +3,7 @@ import type { Changeset } from "@changesets/types";
import writeChangeset from "@changesets/write"; import writeChangeset from "@changesets/write";
import { createFixture } from "fs-fixture"; import { createFixture } from "fs-fixture";
import { beforeEach, describe, expect, it, vi } from "vitest"; import { beforeEach, describe, expect, it, vi } from "vitest";
import { Git } from "./git.ts"; import { GitHub } from "./github.ts";
import { setupOctokit } from "./octokit.ts";
import { runVersion } from "./run.ts"; import { runVersion } from "./run.ts";
vi.mock("@actions/github", () => ({ vi.mock("@actions/github", () => ({
@@ -21,7 +20,6 @@ vi.mock("@actions/github", () => ({
graphql: mockedGraphql, graphql: mockedGraphql,
}), }),
})); }));
vi.mock("./git.ts");
vi.mock("@changesets/ghcommit/git"); vi.mock("@changesets/ghcommit/git");
let mockedGithubMethods = { let mockedGithubMethods = {
@@ -91,6 +89,13 @@ const writeChangesets = (changesets: Changeset[], cwd: string) => {
return Promise.all(changesets.map((commit) => writeChangeset(commit, cwd))); return Promise.all(changesets.map((commit) => writeChangeset(commit, cwd)));
}; };
const createGithub = (cwd: string) =>
new GitHub({
cwd,
githubToken: "@@GITHUB_TOKEN",
commitMode: "github-api",
});
beforeEach(() => { beforeEach(() => {
vi.clearAllMocks(); vi.clearAllMocks();
}); });
@@ -126,9 +131,7 @@ describe("version", () => {
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
}); });
@@ -161,9 +164,7 @@ describe("version", () => {
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
prDraft: "create", prDraft: "create",
}); });
@@ -197,9 +198,7 @@ describe("version", () => {
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
}); });
@@ -232,9 +231,7 @@ describe("version", () => {
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
}); });
@@ -287,9 +284,7 @@ fluminis divesque vulnere aquis parce lapsis rabie si visa fulmineis.
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
prBodyMaxCharacters: 1000, prBodyMaxCharacters: 1000,
}); });
@@ -346,9 +341,7 @@ fluminis divesque vulnere aquis parce lapsis rabie si visa fulmineis.
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
prBodyMaxCharacters: 500, prBodyMaxCharacters: 500,
}); });
@@ -383,9 +376,7 @@ fluminis divesque vulnere aquis parce lapsis rabie si visa fulmineis.
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
prDraft: "create", prDraft: "create",
}); });
@@ -417,9 +408,7 @@ fluminis divesque vulnere aquis parce lapsis rabie si visa fulmineis.
); );
await runVersion({ await runVersion({
octokit: setupOctokit("@@GITHUB_TOKEN"), github: createGithub(cwd),
githubToken: "@@GITHUB_TOKEN",
git: new Git({ cwd }),
cwd, cwd,
prDraft: "always", prDraft: "always",
}); });
+22 -25
View File
@@ -7,10 +7,10 @@ import {
type ExecOptions, type ExecOptions,
type ExecOutput, type ExecOutput,
} from "@actions/exec"; } from "@actions/exec";
import * as github from "@actions/github"; import { context } from "@actions/github";
import type { PreState } from "@changesets/types"; import type { PreState } from "@changesets/types";
import { type Package, getPackages } from "@manypkg/get-packages"; import { type Package, getPackages } from "@manypkg/get-packages";
import { Git } from "./git.ts"; import type { GitHub } from "./github.ts";
import type { Octokit } from "./octokit.ts"; import type { Octokit } from "./octokit.ts";
import readChangesetState from "./readChangesetState.ts"; import readChangesetState from "./readChangesetState.ts";
import { import {
@@ -57,17 +57,15 @@ const createRelease = async (
tag_name: tagName, tag_name: tagName,
body: changelogEntry.content, body: changelogEntry.content,
prerelease: pkg.packageJson.version.includes("-"), prerelease: pkg.packageJson.version.includes("-"),
...github.context.repo, ...context.repo,
}); });
}; };
type PublishOptions = { type PublishOptions = {
script?: string; script?: string;
fromPackDir?: string; fromPackDir?: string;
githubToken: string;
octokit: Octokit;
createGithubReleases: boolean; createGithubReleases: boolean;
git: Git; github: GitHub;
cwd: string; cwd: string;
}; };
@@ -87,17 +85,16 @@ type PublishResult =
export async function runPublish({ export async function runPublish({
script, script,
fromPackDir, fromPackDir,
githubToken, github,
git,
octokit,
createGithubReleases, createGithubReleases,
cwd, cwd,
}: PublishOptions): Promise<PublishResult> { }: PublishOptions): Promise<PublishResult> {
const { octokit } = github;
let changesetPublishOutput: ExecOutput; let changesetPublishOutput: ExecOutput;
const execOptions: ExecOptions = { const execOptions: ExecOptions = {
cwd, cwd,
ignoreReturnCode: true, ignoreReturnCode: true,
env: { ...process.env, GITHUB_TOKEN: githubToken }, env: { ...process.env, GITHUB_TOKEN: github.getToken() },
}; };
if (script) { if (script) {
@@ -144,7 +141,7 @@ export async function runPublish({
await Promise.all( await Promise.all(
releasedPackages.map(async (pkg) => { releasedPackages.map(async (pkg) => {
const tagName = `${pkg.packageJson.name}@${pkg.packageJson.version}`; const tagName = `${pkg.packageJson.name}@${pkg.packageJson.version}`;
await git.pushTag(tagName); await github.pushTag(tagName);
await createRelease(octokit, { pkg, tagName }); await createRelease(octokit, { pkg, tagName });
}), }),
); );
@@ -166,7 +163,7 @@ export async function runPublish({
releasedPackages.push(pkg); releasedPackages.push(pkg);
if (createGithubReleases) { if (createGithubReleases) {
const tagName = `v${pkg.packageJson.version}`; const tagName = `v${pkg.packageJson.version}`;
await git.pushTag(tagName); await github.pushTag(tagName);
await createRelease(octokit, { pkg, tagName }); await createRelease(octokit, { pkg, tagName });
} }
break; break;
@@ -259,9 +256,7 @@ export async function getVersionPrBody({
type VersionOptions = { type VersionOptions = {
script?: string; script?: string;
githubToken: string; github: GitHub;
git: Git;
octokit: Octokit;
cwd?: string; cwd?: string;
prTitle?: string; prTitle?: string;
commitMessage?: string; commitMessage?: string;
@@ -277,26 +272,25 @@ type RunVersionResult = {
export async function runVersion({ export async function runVersion({
script, script,
githubToken, github,
git,
octokit,
cwd = process.cwd(), cwd = process.cwd(),
prTitle = "Version Packages", prTitle = "Version Packages",
commitMessage = "Version Packages", commitMessage = "Version Packages",
hasPublishScript = false, hasPublishScript = false,
prBodyMaxCharacters = MAX_CHARACTERS_PER_MESSAGE, prBodyMaxCharacters = MAX_CHARACTERS_PER_MESSAGE,
branch = github.context.ref.replace("refs/heads/", ""), branch = context.ref.replace("refs/heads/", ""),
prDraft, prDraft,
}: VersionOptions): Promise<RunVersionResult> { }: VersionOptions): Promise<RunVersionResult> {
const { octokit } = github;
let versionBranch = `changeset-release/${branch}`; let versionBranch = `changeset-release/${branch}`;
let { preState } = await readChangesetState(cwd); let { preState } = await readChangesetState(cwd);
await git.prepareBranch(versionBranch); await github.prepareBranch(versionBranch);
let versionsByDirectory = await getVersionsByDirectory(cwd); let versionsByDirectory = await getVersionsByDirectory(cwd);
const env = { ...process.env, GITHUB_TOKEN: githubToken }; const env = { ...process.env, GITHUB_TOKEN: github.getToken() };
if (script) { if (script) {
await exec(script, undefined, { cwd, env }); await exec(script, undefined, { cwd, env });
@@ -335,9 +329,9 @@ export async function runVersion({
* which GitHub will then react to by closing the PRs) * which GitHub will then react to by closing the PRs)
*/ */
const existingPullRequests = await octokit.rest.pulls.list({ const existingPullRequests = await octokit.rest.pulls.list({
...github.context.repo, ...context.repo,
state: "open", state: "open",
head: `${github.context.repo.owner}:${versionBranch}`, head: `${context.repo.owner}:${versionBranch}`,
base: branch, base: branch,
}); });
core.info( core.info(
@@ -348,7 +342,10 @@ export async function runVersion({
)}`, )}`,
); );
await git.pushChanges({ branch: versionBranch, message: finalCommitMessage }); await github.pushChanges({
branch: versionBranch,
message: finalCommitMessage,
});
const changedPackagesInfo = (await changedPackagesInfoPromises) const changedPackagesInfo = (await changedPackagesInfoPromises)
.filter((x) => x) .filter((x) => x)
@@ -370,7 +367,7 @@ export async function runVersion({
title: finalPrTitle, title: finalPrTitle,
body: prBody, body: prBody,
draft: prDraft !== undefined, draft: prDraft !== undefined,
...github.context.repo, ...context.repo,
}); });
return { return {
+9 -9
View File
@@ -1,6 +1,5 @@
import * as core from "@actions/core"; import * as core from "@actions/core";
import { Git } from "../git.ts"; import { GitHub } from "../github.ts";
import { setupOctokit } from "../octokit.ts";
import { runVersion } from "../run.ts"; import { runVersion } from "../run.ts";
import { getOptionalInput, getRequiredInput } from "../utils.ts"; import { getOptionalInput, getRequiredInput } from "../utils.ts";
@@ -24,26 +23,27 @@ async function main() {
if (prDraft !== undefined && prDraft !== "always" && prDraft !== "create") { if (prDraft !== undefined && prDraft !== "always" && prDraft !== "create") {
throw new Error(`Invalid pr-draft input: ${prDraft}`); throw new Error(`Invalid pr-draft input: ${prDraft}`);
} }
if (commitMode !== "git-cli" && commitMode !== "github-api") {
throw new Error(`Invalid commit-mode input: ${commitMode}`);
}
// If the user needs to change the cwd, set `working-directory` in the step instead // If the user needs to change the cwd, set `working-directory` in the step instead
const cwd = process.cwd(); const cwd = process.cwd();
const octokit = setupOctokit(githubToken); const github = new GitHub({
const git = new Git({
octokit: commitMode === "github-api" ? octokit : undefined,
cwd, cwd,
githubToken,
commitMode,
}); });
if (setupGitUser) { if (setupGitUser) {
core.info("setting git user"); core.info("setting git user");
await git.setupUser(); await github.setupUser();
} }
const { pullRequestNumber } = await runVersion({ const { pullRequestNumber } = await runVersion({
script, script,
githubToken, github,
git,
octokit,
cwd, cwd,
prTitle, prTitle,
commitMessage, commitMessage,